singleton - Is this a valid use of the lock keyword in C#? -


I have a singleton class app settings Aspiknet app, where to check me value and optionally update Have to do. I know that I need to use the locking mechanism to stop multi-threading issues, but can someone verify that the following is a valid approach? 

  private static void validate Validation () (if (AppSetting.Instance .EncryptionKey.Equals (Constants.ENCRYPTION_KEY, string Comprijnkordinl)) {lock (Aepaseting. Instrens) {if (app Setinging Kinstens. Ankripshnkiakwaljh (Sthirank.ansiarseepitian_ke, string Compiriynkordinl)) {Aepasetingkinstens. Ankripshnki = generate New Ankripshnki (); AppSetting.Instance.Save ();}}}}

I have also seen examples where you are present Do not lock in any private sector should protect, but I think that the above approach is more intuitive.

Thank you!

The

the intuitive knowledge may be rich, but those instances the piece of code in the private sector to ensure that the lock is no other app can lock in such a lock that There is an application in the form of deadlock, which is always a good defensive practice.

If this is a small application and you are the only programmer working on it, you might be able to participate with locking on a public area / property (which I anticipate app setting. Is Instance?), But in any other situation, I strongly recommend that you go on the private field route. In the future when someone else, or in the future may have forgotten the details of the implementation of the bit, then in the future you will ensure completely locked down to save debugging time, app settings Take it. Somewhere far away in the code and everything crashes.

I also suggest that if you lose the most, locking is not free, but it is very quick to compare the string, especially since the second time in the lock It needs to be done.

Then, something like this: 

  Private Object _instanceLock = New Object (); Private static zero valid encryption () {lock (appatting.instance._ instanceLock) {if (AppSetting.Instance.EncryptionKey.Equals (Constants.ENCRYPTION_KEY, StringComparison.Ordinal)) {AppSetting.Instance.EncryptionKey = GenerateNewEncryptionKey (); AppSetting.Instance.Save (); }}}

What are your requirements for keeping the compatibility with the rest of the state in episode, besides an additional refinement. Instance will have to use a different private lock object instead of encryption and any associated fields, each time locking the whole instance.


-

Comments

Post a Comment

Popular posts from this blog

Eclipse CDT variable colors in editor -

I hope this is a good question to ask here. This programming is related, so I thought it would be better than the superuser, so I am using the CDT C ++ Eclipse plugin. I know how the editor changes colors for some things But is there a way to do that all the variables are different colors? For example in KDEValue, it sets the local variables and square variables in different colors and bold square squares. Can I copy it to CDT? Eclips provides some level of color customization for text editor syntax You can see it on the following: There are many elements, including the Window> Preferences> C / C ++> Editor> Syntax color code that can be changed, assembly, Comments, Preprocessor and Doxian Under the code, it is possible to change the color of some variable types, such as global variables, local variable announcements, local variable references, and parameter variables. But I do not think the code is capable of changing the color of each variable declared....
Read more

AJAX doesn't send POST query -

$ (दस्तावेज़) .ready (function () {function ajaxselectrss (rssurlvar) {var ajaxRequest; // वेरिएबल जो अजाक्स को संभव बनाता है! कोशिश करें कि {// ओपेरा 8.0+, फ़ायरफ़ॉक्स, सफारी अजाक्स अनुरोध} = नया एक्सएमएलएचटीपीआरइवेस्ट ();} कैच (ई) {// इंटरनेट एक्सप्लोरर ब्राउज़र्स {ajaxRequest = new ActiveXObject ("Msxml2.XMLHTTP");} पकड़ो (ई) {try {ajaxRequest = new ActiveXObject ("Microsoft.XMLHTTP");} कैच (ई) {// कुछ गलत चेतावनी ("आपका ब्राउज़र तोड़ दिया!"); वापसी झूठी;}}} // एक बनाएं फ़ंक्शन जो सर्वर से भेजे गए डेटा प्राप्त करेंगे ajaxRequest.onreadystatechange = function () {if (ajaxRequest.readyState == 4) {var ajaxDisplay = document.getElementById ('news'); ajaxDisplay.innerHTML = ajaxRequest.responseText;}} / / Var rssurlvar = $ (this) .attr ("title"); var queryString = "rurl =" + rssurlvar; var urltofile = "rssget.php"; ajaxRequest.open ("पोस्ट", urltofile, सच); ajaxRequ Est.setRequestHeader ("सामग्री-प्र...
Read more

wpf - Custom Message Box Advice -

Well, I'm using a custom window box that comes with some custom control boxes that accompany the text The producers who are displayed are called. I have a defined event, which has been subscribed through the original class, it gets burnt when clicking on the button. However, I can not see how to use it effectively, I would like to return one yes, whether yes or not, but obviously my code will continue to execute, so this Below is some example code to clarify the problem that the method has subscibed by clicking on the button. Message box window Public partial class custom message box: window {public representative message messagebox object sender, event events e); Public event messagebox handler messagebox document; Public Customs Box () {Initial group (); } Public Customsbox (String Message) {InitializeComponent (); This.txtdescription.Text = Message; } Public Customsbox (String Message, String Title, String First BTNtext) {Initialization (); This.lbltitle.Content =...
Read more