c# - How to refactor this routine to avoid the use of recursion? -


I was writing exercise in C # and although it Works, looking back at the code, was the place for improvement.

Basically, the second part of the algorithm to merge two sorted lists is a regular requirement.

My method is very long implementation which can use some refactoring: 

  Private static list & lt; Int & gt; MergeSortedLists (& lt; integer & gt; sLeft of the list, & lt; integer & gt; sRight from the list) {if (sLeft.Count == 0 || sRight.Count == 0) {sLeft.AddRange (sRight); Return SLAF; } And if (sLeft.Count == 1 & amp;;; .right.Count == 1) {If (S left [0]  1) {for (int i = 0; I & lt; sRight.Count; i ++) {if (sLeft [ 0] & lt; = sRight [i]) {SRight.Instert (i, sLeft [0]); Return sRight; }} SRight.Add (sLeft [0]); Return sRight; } Else if (sLeft.Count> 1 & amp; & amp; amp; sRight.Count == 1) {if (sRight [i = 0; I & lt; sLeft.Count; i ++) for {if (sRight [ 0] & lt; = sLeft [i]) {SLeft.Insert (i, sRight [0]); Return SLAF; }} SLeft.Add (sRight [0]); Return SLAF; } And {list & lt; Int & gt; List = new list & lt; Int & gt; (); If (sLeft [0]

Certainly this routine can be corrected / abrogated by removing recursion , etc. 2 There are other ways to merge sorted lists. Therefore, any is welcome for refactoring.

Although I have the answer, I am curious that other programmers will have to make this routine How to see improvements.

Thank you!

As a starting point, I will count your particular cases when any of the counts == 1 - Your more general (currently recurring) can be controlled by case.

if (sLeft.Count> gt;); 1 & amp; Amp; Sight.Qount == 0) Anytime will not be correct because you have checked for sRight. Number == 0 initially - so this code will never reach and is redundant.

Finally, instead of recursive (due to the number of new lists created by you, this is very expensive in this case - a copy element!), Something like in your else Do (in fact, it can replace your entire method): 

  list & lt; Int & gt; List = new list & lt; Int & gt; (); While (sLeft.Count> 0 & amp;; ;; Wright; gt; 0) {if (SLEFT [0] & lt; = sRight [0]) {list.ed (SLEFT [0]) ; SLeft.RemoveAt (0); } And {list.Add (sRight [0]); SRight.RemoveAt (0); }} // One of these two is already empty; The other is in sequential order ... list. Additional Range (sLeft); List.AddRange (sRight); Return list;

(Ideally I reapply it to use integer indexes against each list instead of using .move_clickAt , and because It may be useful to leave the original lists intact, though it is still a more efficient code than the original!)


-

Comments

Post a Comment

Popular posts from this blog

Eclipse CDT variable colors in editor -

I hope this is a good question to ask here. This programming is related, so I thought it would be better than the superuser, so I am using the CDT C ++ Eclipse plugin. I know how the editor changes colors for some things But is there a way to do that all the variables are different colors? For example in KDEValue, it sets the local variables and square variables in different colors and bold square squares. Can I copy it to CDT? Eclips provides some level of color customization for text editor syntax You can see it on the following: There are many elements, including the Window> Preferences> C / C ++> Editor> Syntax color code that can be changed, assembly, Comments, Preprocessor and Doxian Under the code, it is possible to change the color of some variable types, such as global variables, local variable announcements, local variable references, and parameter variables. But I do not think the code is capable of changing the color of each variable declared....
Read more

AJAX doesn't send POST query -

$ (दस्तावेज़) .ready (function () {function ajaxselectrss (rssurlvar) {var ajaxRequest; // वेरिएबल जो अजाक्स को संभव बनाता है! कोशिश करें कि {// ओपेरा 8.0+, फ़ायरफ़ॉक्स, सफारी अजाक्स अनुरोध} = नया एक्सएमएलएचटीपीआरइवेस्ट ();} कैच (ई) {// इंटरनेट एक्सप्लोरर ब्राउज़र्स {ajaxRequest = new ActiveXObject ("Msxml2.XMLHTTP");} पकड़ो (ई) {try {ajaxRequest = new ActiveXObject ("Microsoft.XMLHTTP");} कैच (ई) {// कुछ गलत चेतावनी ("आपका ब्राउज़र तोड़ दिया!"); वापसी झूठी;}}} // एक बनाएं फ़ंक्शन जो सर्वर से भेजे गए डेटा प्राप्त करेंगे ajaxRequest.onreadystatechange = function () {if (ajaxRequest.readyState == 4) {var ajaxDisplay = document.getElementById ('news'); ajaxDisplay.innerHTML = ajaxRequest.responseText;}} / / Var rssurlvar = $ (this) .attr ("title"); var queryString = "rurl =" + rssurlvar; var urltofile = "rssget.php"; ajaxRequest.open ("पोस्ट", urltofile, सच); ajaxRequ Est.setRequestHeader ("सामग्री-प्र...
Read more

wpf - Custom Message Box Advice -

Well, I'm using a custom window box that comes with some custom control boxes that accompany the text The producers who are displayed are called. I have a defined event, which has been subscribed through the original class, it gets burnt when clicking on the button. However, I can not see how to use it effectively, I would like to return one yes, whether yes or not, but obviously my code will continue to execute, so this Below is some example code to clarify the problem that the method has subscibed by clicking on the button. Message box window Public partial class custom message box: window {public representative message messagebox object sender, event events e); Public event messagebox handler messagebox document; Public Customs Box () {Initial group (); } Public Customsbox (String Message) {InitializeComponent (); This.txtdescription.Text = Message; } Public Customsbox (String Message, String Title, String First BTNtext) {Initialization (); This.lbltitle.Content =...
Read more